test(NODE-3288): sync command-monitoring spec tests #2837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
durran
reviewed
Jun 15, 2021
| filterOutCommands, | ||
| ignoreNsNotFound | ||
| } = require('./shared'); | ||
| const { loadSpecTests } = require('../spec'); |
There was a problem hiding this comment.
Maybe we rename this to command_monitoring.test.js to match the directory name change? Or would you rather do that as part of the greater test cleanup? I'm fine either way.
There was a problem hiding this comment.
I thought about doing it, but (1) I wasn't sure if we had in progress work touching this file and what potential merge conflict issues that might cause and (2) there are a lot of references to APM throughout and as you pointed out, the greater test refactor later is likely going to change a lot of things around, so not sure it's worth doing it
There was a problem hiding this comment.
Yeah I think it's fine to wait. LGTM.
durran
approved these changes
Jun 15, 2021
nbbeeken
approved these changes
Jun 15, 2021
dariakp
force-pushed
the
NODE-3288/add-test-for-security-sensitive-event-redaction
branch
from
da577c3 to
cbe0f89
Compare
durran
deleted the
NODE-3288/add-test-for-security-sensitive-event-redaction
branch
ljhaywar
pushed a commit
that referenced
this pull request
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NODE-3288
see also #2838