refactor(NODE-3356): Remove logs that duplicate command monitoring functionality #2851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
approved these changes
Jun 17, 2021
durran
approved these changes
Jun 20, 2021
There was a problem hiding this comment.
I like this refactoring. It was always expected with the command monitoring spec that a logger itself would be registering itself to all our monitoring if the users wanted easy debug, and this is how we originally implemented it in the Ruby driver at least and I believe there was discussion for the same for Node in the past that just got deprioritised. This puts us in the right direction - nice job.
emadum
suggested changes
Jun 21, 2021
Oh that's weird, I could have sworn I saw them pass earlier; I'll look into it, thanks for the catch! @emadum |
dariakp
force-pushed
the
NODE-3356/4.0/debug-logs
branch
from
57c1131 to
3031fde
Compare
emadum
approved these changes
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NODE-3356