feat!(NODE-3094): improve dots-and-dollars in keys experience #2863
Conversation
| const collection = entities.getEntity('collection', operation.object); | ||
| const { filter, replacement, ...opts } = operation.arguments; | ||
| return collection.findOneAndReplace(filter, replacement, translateOptions(opts)); | ||
| return (await collection.findOneAndReplace(filter, replacement, translateOptions(opts))).value; |
There was a problem hiding this comment.
This matches what findOneAndUpdate does below
dariakp
added
the
Primary Review
|
Also, let's make sure that any legitimate updates to the unified spec runner get ported to 3.6/3.7 |
@dariakp Since I have fairly little knowledge of what exactly that means, please let me know if there is something to do for me here :) |
This is just a housekeeping note for the team to either open a jira ticket or create a PR for the 3.6 or 3.7 branch in order to keep the unified runner implementations in sync once we determine what changes are needed, nothing for you to worry about @addaleax :) |
nbbeeken
added
Team Review
There was a problem hiding this comment.
mongodb/specifications@fc21cb7
We have a fix in the specs for the insertedCount if you could pull in the latest please and thanks!
Cherry-pick the changes from: - mongodb/specifications@a124e21 - mongodb/specifications@851ca10 - mongodb/specifications@fc21cb7 (because a full update didn’t seem feasible at this point) and update the code and non-spec tests to match the relaxed naming restrictions.
nbbeeken
changed the title
Description
What changed?
Cherry-pick the changes from:
(because a full update didn’t seem feasible at this point)
and update the code and non-spec tests to match the relaxed
naming restrictions.
Are there any files to ignore?
Spec file changes, I assume.