test(NODE-3072): serverless testing #2905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emadum
changed the title
emadum
force-pushed
the
NODE-3072/4.0/serverless-testing
branch
from
8708efb to
25b35cb
Compare
emadum
force-pushed
the
NODE-3072/4.0/serverless-testing
branch
from
3eb38b1 to
5db4f1c
Compare
emadum
force-pushed
the
NODE-3072/4.0/serverless-testing
branch
from
30139a4 to
b989106
Compare
nbbeeken
added
the
Primary Review
nbbeeken
suggested changes
Aug 10, 2021
Comment on lines
+7
to
+13
| MONGODB_URI=${MONGODB_URI} npx mocha \ | ||
| test/functional/crud_spec.test.js \ | ||
| test/functional/retryable_reads.test.js \ | ||
| test/functional/retryable_writes.test.js \ | ||
| test/functional/sessions.test.js \ | ||
| test/functional/transactions.test.js \ | ||
| test/functional/versioned-api.test.js |
There was a problem hiding this comment.
Is this list specified in a spec or something? I foresee us changing filenames / commands for our upcoming test upgrades, what do we need to filter on here?
There was a problem hiding this comment.
Yes this list comes from the spec:
Tests defined in the following specifications MUST be included in a driver's
Atlas Serverless testing suite, including prose tests:
- CRUD, including the v1 and unified tests
- Retryable Writes
- Retryable Reads
- Versioned API
- Driver Sessions
- Transactions (excluding convenient API)
nbbeeken
approved these changes
Aug 12, 2021
nbbeeken
added
Team Review
dariakp
requested changes
Aug 12, 2021
dariakp
approved these changes
Aug 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds testing against "proxy as mongos"