Skip to content

test(NODE-3468): Add tests for a strongly-typed Db #2937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 16, 2021
Merged

test(NODE-3468): Add tests for a strongly-typed Db #2937

merged 4 commits into from
Aug 16, 2021

Conversation

ephemer
Copy link
Contributor

@ephemer ephemer commented Aug 16, 2021 •
edited
Loading

NODE-3468

Description

What changed?

The added tests ensure that users who re-use a single db object can define which collections are available on that Db, as well as the types those collections contain.

@ephemer
test(NODE-3468): Add tests for a strongly-typed Db
8b31d4d 
This allows users who re-use a single db object to define which collections are available on that Db, as well as the types those collections contain.

NODE-3468
dariakp
dariakp requested changes Aug 16, 2021
View reviewed changes
Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for providing additional tests, just need to update the type to also accept undefined as noted below, otherwise these typescript tests are going to fail, since findOne can also return undefined.

ephemer and others added 3 commits August 16, 2021 16:08
@ephemer @dariakp
Update test/types/community/collection/findX.test-d.ts
a2f82e1 
Co-authored-by: Daria Pardue <81593090+dariakp@users.noreply.github.com>
@ephemer @dariakp
Update test/types/community/collection/findX.test-d.ts
6691b3e 
Co-authored-by: Daria Pardue <81593090+dariakp@users.noreply.github.com>
@ephemer @dariakp
Update test/types/community/collection/findX.test-d.ts
a2a43e5 
Co-authored-by: Daria Pardue <81593090+dariakp@users.noreply.github.com>
@ephemer
Copy link
Contributor Author

ephemer commented Aug 16, 2021

Done! @dariakp

@dariakp dariakp self-requested a review August 16, 2021 14:14
@dariakp dariakp added the Team Review Needs review from team label Aug 16, 2021
@dariakp dariakp requested a review from nbbeeken August 16, 2021 14:15
@dariakp dariakp self-assigned this Aug 16, 2021
@dariakp dariakp requested a review from emadum August 16, 2021 14:15
nbbeeken
nbbeeken approved these changes Aug 16, 2021
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again! LGTM

@dariakp dariakp merged commit ead5fa6 into mongodb:4.1 Aug 16, 2021
@ephemer ephemer deleted the addFindTypeTests branch August 16, 2021 14:34
ljhaywar pushed a commit that referenced this pull request Nov 9, 2021
@ephemer @ljhaywar
test(NODE-3468): Add tests for a strongly-typed Db (#2937)
b4854c3 
This allows users who re-use a single db object to define which collections are available on that Db, as well as the types those collections contain.

NODE-3468
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dariakp dariakp dariakp approved these changes

+2 more reviewers

@emadum emadum emadum approved these changes

@nbbeeken nbbeeken nbbeeken approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dariakp dariakp

Labels

Team Review Needs review from team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ephemer @emadum @nbbeeken @dariakp