Skip to content

docs: Clarify that deprecation is a "feat" type commit #3052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2021
Merged

docs: Clarify that deprecation is a "feat" type commit #3052

merged 1 commit into from
Dec 3, 2021

Conversation

ljhaywar
Copy link
Contributor

Description

What is changing?

Update to the contributing guidelines to indicate that a feature deprecation is a "feat" commit type

Is there new documentation needed for these changes?

No

What is the motivation for this change?

I wasn't sure what commit type to use when I deprecated a feature

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@ljhaywar ljhaywar self-assigned this Nov 19, 2021
@durran durran self-requested a review November 22, 2021 13:32
@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Nov 22, 2021
@durran durran changed the base branch from 4.1 to main November 22, 2021 13:33
@durran
Copy link
Member

durran commented Nov 22, 2021

Changed base branch to main.

durran
durran requested changes Nov 22, 2021
View reviewed changes
Copy link
Member

@durran durran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ljhaywar Could you rebase again please - I changed the base branch to main so it shows up in the default repo but there are some conflicts now.

@nbbeeken nbbeeken changed the title <docs>: Clarify that deprecation is a "feat" type commit docs: Clarify that deprecation is a "feat" type commit Nov 29, 2021
@ljhaywar ljhaywar force-pushed the clarify-deprecation-is-a-feature-commit branch from 073baef to e5aca1b Compare November 30, 2021 14:43
@ljhaywar
Copy link
Contributor Author

ljhaywar commented Nov 30, 2021 •
edited
Loading

Thanks for catching that, @durran! I've rebased.

@dariakp dariakp requested a review from durran December 2, 2021 17:24
nbbeeken
nbbeeken approved these changes Dec 2, 2021
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this fell off the radar, seems ready to merge!

@dariakp dariakp merged commit 0d80847 into main Dec 3, 2021
@dariakp dariakp deleted the clarify-deprecation-is-a-feature-commit branch December 3, 2021 15:45
@durran durran added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@durran durran durran approved these changes

+1 more reviewer

@nbbeeken nbbeeken nbbeeken approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ljhaywar ljhaywar

Labels

Team Review Needs review from team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ljhaywar @durran @nbbeeken @dariakp