fix(NODE-3705): ReadPreference.fromOptions omitting hedge and maxStalenessSeconds when readPreference is a string #3060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
suggested changes
Nov 30, 2021
nbbeeken
reviewed
Nov 30, 2021
nbbeeken
added
the
Primary Review
- Add tests covering the maxStalenessSeconds parameter - Add tests covering error scenarios for maxStalenessSeconds && hedge
baileympearson
changed the title
nbbeeken
suggested changes
Nov 30, 2021
nbbeeken
added
Team Review
…into NODE-3705/enable-hedge-options-when-readPreference-is-string
nbbeeken
approved these changes
Nov 30, 2021
Signed-off-by: Bailey Pearson <bailey.pearson@mongodb.com>
dariakp
approved these changes
Dec 1, 2021
nbbeeken
changed the title
nbbeeken
deleted the
NODE-3705/enable-hedge-options-when-readPreference-is-string
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prior to these changes, when
ReadPreference.fromOptionswas passed astringfor the read preference, hedge configuration and maxStalenessSeconds were not set on theReadPreferenceobject. This PR passes hedge configuration and maxStalenessSeconds configuration through to the read preference object when it is created usingReadPreference.fromOptionswith a string as the read preference.Additionally, this PR moves unit tests for the ReadPreference class into the unit test suite from the functional test suite.
Double check the following
npm run check:lintscript<type>(NODE-xxxx)<!>: <description>