-
Notifications
You must be signed in to change notification settings - Fork 1.8k
refactor(NODE-3788): update names of offensive error codes #3063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
baileympearson
merged 6 commits into
main
from
NODE-3788/update-names-of-offensive-error-codes
Dec 6, 2021
Merged
refactor(NODE-3788): update names of offensive error codes #3063
baileympearson
merged 6 commits into
main
from
NODE-3788/update-names-of-offensive-error-codes
Dec 6, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Questions:
|
|
durran
previously requested changes
Dec 3, 2021
durran
reviewed
Dec 3, 2021
We're seeing the same test failures in more than one PR, so I don't think these failures are related to the code changes. @baileympearson this is ready for your review |
ffac9f6
to
3875192
Compare
nbbeeken
suggested changes
Dec 6, 2021
nbbeeken
approved these changes
Dec 6, 2021
baileympearson
approved these changes
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NODE-3788
What is changing?
The tests that reference these error codes are spec tests. Updates to those tests are covered in NODE-3791.
Is there new documentation needed for these changes?
No
What is the motivation for this change?
Following the guidance documented in https://tools.ietf.org/id/draft-knodel-terminology-00.html, we will remove all oppressive and unnecessarily gendered language in driver documentation, code, tests, specs, and spec tests.
Double check the following
npm run check:lint
script<type>(NODE-xxxx)<!>: <description>
New TODOs have a related JIRA ticket