Skip to content

Conversation

dariakp
Copy link
Contributor

@dariakp dariakp commented Dec 2, 2021

Description

NODE-3717

What is changing?

  • crud and bulk tests were moved to integration/crud; one prose test was separated into a prose file from bulk
  • max staleness test were moved to integration/max-staleness - they use a mock server but I think it's better to make them into proper integration tests than convert to a unit test (see my comment on this PR and new ticket)
  • load balancer, retryable reads, and retryable writes tests have all been moved into a corresponding integration directory

NOTE: The changes in this PR affect the configuration for run-serverless-tests.sh we should double check to make sure all desired tests are still running (see my comment on that file).

Is there new documentation needed for these changes?

N/A

What is the motivation for this change?

Better test organization

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • [N/A] Changes are covered by tests
  • New TODOs have a related JIRA ticket

@dariakp dariakp added the wip label Dec 2, 2021
@dariakp dariakp force-pushed the NODE-3717/reorganize-tests-pt2 branch from bbfb8c0 to 4094c87 Compare December 2, 2021 22:55
@dariakp dariakp force-pushed the NODE-3717/reorganize-tests-pt2 branch from c44d855 to baf179c Compare December 2, 2021 22:59
@dariakp dariakp force-pushed the NODE-3717/reorganize-tests-pt2 branch from 8e8ef45 to f826dab Compare December 2, 2021 23:16
@dariakp dariakp changed the title WIP: refactor(NODE-3717): reorganize tests part 2 refactor(NODE-3717): reorganize tests part 2 Dec 2, 2021
@dariakp dariakp added Team Review Needs review from team and removed wip labels Dec 2, 2021
@dariakp dariakp marked this pull request as ready for review December 2, 2021 23:38
@dariakp dariakp requested review from durran and nbbeeken December 2, 2021 23:38
@durran
Copy link
Member

durran commented Dec 3, 2021

I'm leaving the conversations unresolved so anyone else who wants a look can see them easily, but feel free to resolve them yourself when you want to merge. LGTM.

@dariakp dariakp merged commit 91ae3e6 into main Dec 3, 2021
@dariakp dariakp deleted the NODE-3717/reorganize-tests-pt2 branch December 3, 2021 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team Review Needs review from team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants