-
Notifications
You must be signed in to change notification settings - Fork 1.8k
refactor(NODE-3717): reorganize tests part 2 #3064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariakp
commented
Dec 2, 2021
bbfb8c0
to
4094c87
Compare
c44d855
to
baf179c
Compare
dariakp
commented
Dec 2, 2021
8e8ef45
to
f826dab
Compare
dariakp
commented
Dec 2, 2021
durran
approved these changes
Dec 3, 2021
I'm leaving the conversations unresolved so anyone else who wants a look can see them easily, but feel free to resolve them yourself when you want to merge. LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NODE-3717
What is changing?
integration/crud
; one prose test was separated into a prose file from bulkintegration/max-staleness
- they use a mock server but I think it's better to make them into proper integration tests than convert to a unit test (see my comment on this PR and new ticket)NOTE: The changes in this PR affect the configuration for
run-serverless-tests.sh
we should double check to make sure all desired tests are still running (see my comment on that file).Is there new documentation needed for these changes?
N/A
What is the motivation for this change?
Better test organization
Double check the following
npm run check:lint
script<type>(NODE-xxxx)<!>: <description>