Skip to content

Conversation

dariakp
Copy link
Contributor

@dariakp dariakp commented Dec 3, 2021

Description

NODE-3801

What is changing?

Updated the currently failing tests to consistently check for indicator properties anywhere in the response object, regardless of nesting level. The property "queryPlanner" should be present in all cases. The property "executionStats" should only be present when additional verbosity is requested.

Is there new documentation needed for these changes?

No

What is the motivation for this change?

Latest server changed the shape of the explain output, so we need to update our tests to make our CI green again.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • [N/A] New TODOs have a related JIRA ticket

@dariakp dariakp added the Team Review Needs review from team label Dec 3, 2021
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clever trick checking the JSON string! 🚀

@dariakp dariakp merged commit bcc57d6 into main Dec 4, 2021
@dariakp dariakp deleted the NODE-3801/fix-explain-query-latest-tests branch December 4, 2021 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team Review Needs review from team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants