Skip to content

test(NODE-4282): sync fle2 payload spec test updates #3309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jul 8, 2022
Merged

test(NODE-4282): sync fle2 payload spec test updates #3309

merged 12 commits into from
Jul 8, 2022

Conversation

durran
Copy link
Member

@durran durran commented Jun 30, 2022 •
edited
Loading

Description

Fixes FLE2 CRUD tests with payload updates.

What is changing?

Syncs the latest tests and pins the checkout of libmongocrypt to 4c3715bbe360a6e87f411d63f5bd1dc237b2f5cb (1.5.0)

Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-4282

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran durran changed the title test(NODE-4284): sync fle2 payload spec test updates test(NODE-4282): sync fle2 payload spec test updates Jun 30, 2022
@durran durran marked this pull request as ready for review June 30, 2022 17:04
@dariakp dariakp self-assigned this Jun 30, 2022
@dariakp dariakp added Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Jun 30, 2022
dariakp
dariakp reviewed Jun 30, 2022
View reviewed changes
Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just have a question here

@dariakp dariakp added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Jun 30, 2022
@durran
Copy link
Member Author

durran commented Jul 1, 2022 •
edited
Loading

These errors: Uncaught TypeError: contention factor is required for indexed algorithm are fixed by mongodb/libmongocrypt#397

nbbeeken
nbbeeken previously approved these changes Jul 5, 2022
View reviewed changes
dariakp
dariakp previously approved these changes Jul 5, 2022
View reviewed changes
@dariakp dariakp dismissed their stale review July 5, 2022 15:36

checking tests

@durran
Copy link
Member Author

durran commented Jul 6, 2022

Once the alpha.4 artefacts are published to Github I'll update this PR to point at that and the regular fle tests will pass with the exception of the 1 timeout failure. Looking into that now.

@dariakp dariakp merged commit 3c5bcb9 into main Jul 8, 2022
@dariakp dariakp deleted the NODE-4282 branch July 8, 2022 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dariakp dariakp dariakp approved these changes

@baileympearson baileympearson Awaiting requested review from baileympearson

+1 more reviewer

@nbbeeken nbbeeken nbbeeken approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@dariakp dariakp

Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@durran @nbbeeken @dariakp