Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(NODE-6243): move Node release tooling to drivers-github-tools #4159

Merged
merged 13 commits into from
Jun 27, 2024

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Jun 24, 2024

Description

What is changing?

Relies on mongodb-labs/drivers-github-tools#45. ✅

This PR adjust the driver's release to use shared release tooling for the node team from drivers-github-tools/node.

It turns out that sharing workflows requires workflow files to be put in the .github/workflows folder. So unless we want to have node-specific release actions in the .github/workflows folder in drivers-github-tools, we can't re-use workflows as a whole. I chose not to shared workflows and instead generate release files (see the generation script in drivers-github-tools).

Once mongodb-labs/drivers-github-tools#45 merges, I will update this PR so that it no longer points to my fork. ✅

Example GHA run: https://github.com/mongodb/node-mongodb-native/actions/runs/9700110739

Is there new documentation needed for these changes?

What is the motivation for this change?

Release Highlight

Fill in title or leave empty for no highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

Copy link

There is an existing patch(es) for this commit SHA:

Please note that the status that is posted is not in the context of this PR but rather the (latest) existing patch and that may affect some tests that may depend on the particular PR. If your tests do not rely on any PR-specific values (like base or head branch name) then your tests will report the same status. If you would like a patch to run in the context of this PR and abort the other(s), comment 'evergreen retry'.

@baileympearson baileympearson changed the title use shared actions chore(NODE-6243): move Node release tooling to drivers-github-tools Jun 25, 2024
@baileympearson baileympearson marked this pull request as ready for review June 25, 2024 17:01
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm feel free to merge

@durran durran added the Team Review Needs review from team label Jun 27, 2024
@baileympearson baileympearson merged commit 9f447e9 into main Jun 27, 2024
27 of 29 checks passed
@baileympearson baileympearson deleted the clean-up-release branch June 27, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants