-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(NODE-6243): move Node release tooling to drivers-github-tools #4159
Conversation
There is an existing patch(es) for this commit SHA: Please note that the status that is posted is not in the context of this PR but rather the (latest) existing patch and that may affect some tests that may depend on the particular PR. If your tests do not rely on any PR-specific values (like base or head branch name) then your tests will report the same status. If you would like a patch to run in the context of this PR and abort the other(s), comment 'evergreen retry'. |
e0280c1
to
22d6dc4
Compare
f367ece
to
9c44272
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm feel free to merge
Description
What is changing?
Relies on mongodb-labs/drivers-github-tools#45. ✅
This PR adjust the driver's release to use shared release tooling for the node team from drivers-github-tools/node.
It turns out that sharing workflows requires workflow files to be put in the
.github/workflows
folder. So unless we want to have node-specific release actions in the .github/workflows folder in drivers-github-tools, we can't re-use workflows as a whole. I chose not to shared workflows and instead generate release files (see the generation script in drivers-github-tools).Once mongodb-labs/drivers-github-tools#45 merges, I will update this PR so that it no longer points to my fork. ✅
Example GHA run: https://github.com/mongodb/node-mongodb-native/actions/runs/9700110739
Is there new documentation needed for these changes?
What is the motivation for this change?
Release Highlight
Fill in title or leave empty for no highlight
Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript