Skip to content

Conversation

PavelSafronov
Copy link
Contributor

Description

Summary of Changes

Migrating node-mongodb-native/test/unit driver callback API style tests to promises.

What is the motivation for this change?

https://jira.mongodb.org/browse/NODE-4979

We want to modify all tests to no longer use callbacks as the driver is a promise only API now. This is a requirement for deprecating the legacy driver.

Double check the following

  • Lint is passing (npm run check:lint)
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@PavelSafronov PavelSafronov requested a review from a team as a code owner September 23, 2025 17:00
Copy link
Contributor

@baileympearson baileympearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is red, including a number of failures that are not present on main.

@baileympearson baileympearson self-assigned this Sep 23, 2025
@baileympearson baileympearson added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Sep 23, 2025
@PavelSafronov
Copy link
Contributor Author

CI is red, including a number of failures that are not present on main.

Strange, looks like test/integration/client-side-encryption/client_side_encryption.prose.21.automatic_data_encryption_keys.test.ts is encountering errors, though this PR only changes test/unit. Looking into this.

@baileympearson baileympearson merged commit 6986355 into mongodb:main Sep 25, 2025
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants