Skip to content

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Sep 25, 2025

Description

Summary of Changes

The release action was failing because create-pull-request was running in a separate stage from the docs generation and was not checking out the repo. Adding a checkout step does not fix the issue, because any docs changes made by the previous stage are not present in the newly cloned repo.

I resolve this issue by making the documentation build action a composite action instead, which can be called inside the same stage as create-pull-request.

Example release PR generated from the action: #4682

Notes for Reviewers

What is the motivation for this change?

Release Highlight

Release notes highlight

Double check the following

  • Lint is passing (npm run check:lint)
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson marked this pull request as ready for review September 25, 2025 20:29
@baileympearson baileympearson requested a review from a team as a code owner September 25, 2025 20:29
@durran durran merged commit 2bd2c3a into main Sep 26, 2025
24 of 27 checks passed
@durran durran deleted the fix-docs branch September 26, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants