Skip to content

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Oct 1, 2025

Description

Summary of Changes

This PR removes crypto callbacks from the driver. Like other breaking FLE PRs, CI is red and will be until the FLE changes are released. The custom dependency tests are using the corresponding mongodb-client-encryption changes and are passing.

Notes for Reviewers

What is the motivation for this change?

Release Highlight

Release notes highlight

Double check the following

  • Lint is passing (npm run check:lint)
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

describe('ClientEncryption', function () {
this.timeout(12000);

context('with stubbed key material and fixed random source', function () {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have coverage for ClientEncryption in our integration tests.

@baileympearson baileympearson marked this pull request as ready for review October 1, 2025 17:37
@baileympearson baileympearson requested a review from a team as a code owner October 1, 2025 17:37
@durran durran self-assigned this Oct 1, 2025
@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Oct 1, 2025
@durran durran merged commit 00cf2cd into NODE-7043-error-wrapper Oct 1, 2025
6 of 20 checks passed
@durran durran deleted the NODE-6297 branch October 1, 2025 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants