Skip to content

SPEC-1353 and small test fix #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

SPEC-1353 and small test fix #591

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a523040
SPEC-1353 mandate that connections are cleared as per new tests
samantharitter Jul 3, 2019
3f03188
failCommand only available on servers 4.0 and later
samantharitter Jul 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions source/connections-survive-step-down/tests/README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ This test requires server version 4.2 or higher.
Not Master - Reset Connection Pool
``````````````````````````````````

This test requires server version 4.0 or lower.
This test requires server version 4.0.


- Set the following fail point: ``{configureFailPoint: "failCommand", mode: {times: 1},
Expand All @@ -124,7 +124,7 @@ This test requires server version 4.0 or lower.
Shutdown in progress - Reset Connection Pool
````````````````````````````````````````````

This test should be run on all supported server versions.
This test should be run on all server versions >= 4.0.

Perform the following operations on a client configured to NOT retry writes:

Expand All @@ -139,7 +139,7 @@ Perform the following operations on a client configured to NOT retry writes:
Interrupted at shutdown - Reset Connection Pool
```````````````````````````````````````````````

This test should be run on all supported server versions.
This test should be run on all server versions >= 4.0.

Perform the following operations on a client configured to NOT retry writes:

Expand Down
8 changes: 4 additions & 4 deletions source/server-discovery-and-monitoring/server-discovery-and-monitoring-summary.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ Server Discovery And Monitoring -- Summary
:Advisors: David Golden, Craig Wilson
:Status: Draft
:Type: Standards
:Last Modified: September 8, 2014
:Last Modified: July 11, 2019

.. contents::

Expand Down Expand Up @@ -212,7 +212,7 @@ the behavior is different from a failed application operation.
The ismaster call is retried once, immediately,
before the server is marked "down".

In either case the client SHOULD clear its connection pool for the server:
In either case the client MUST clear its connection pool for the server:
if one socket is bad, it is likely that all are.

An algorithm is specified for parsing
Expand All @@ -221,6 +221,6 @@ When the client sees such an error it knows its topology view is out of date.
It MUST mark the server type "unknown."
Multi-threaded and asynchronous clients MUST re-check the server soon,
and single-threaded clients MUST request a scan before the next operation.
The client SHOULD clear its connection pool for the server if the
server is 4.0 or earlier, and SHOULD NOT clear its connection pool for the
The client MUST clear its connection pool for the server if the
server is 4.0 or earlier, and MUST NOT clear its connection pool for the
server if the server is 4.2 or later.
10 changes: 5 additions & 5 deletions source/server-discovery-and-monitoring/server-discovery-and-monitoring.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ Server Discovery And Monitoring
:Advisors: David Golden, Craig Wilson
:Status: Accepted
:Type: Standards
:Version: 2.13
:Last Modified: 2019-05-29
:Version: 2.14
:Last Modified: 2019-07-11

.. contents::

Expand Down Expand Up @@ -1233,9 +1233,9 @@ updateRSFromPrimary
see `multi-threaded or asynchronous monitoring`_.)

If the old primary server version is 4.0 or earlier,
the client SHOULD clear its connection pool for the old primary, too:
the client MUST clear its connection pool for the old primary, too:
the connections are all bad because the old primary has closed its sockets.
If the old primary server version is 4.2 or newer, the client SHOULD NOT
If the old primary server version is 4.2 or newer, the client MUST NOT
clear its connection pool for the old primary.

See `replica set monitoring with and without a primary`_.
Expand Down Expand Up @@ -1372,7 +1372,7 @@ referring to the table above we see the subroutine is `checkIfHasPrimary`_.
The result is the TopologyType changes to ReplicaSetNoPrimary.
See the test scenario called "Network error writing to primary".

The client SHOULD close all idle sockets in its connection pool for the server:
The client MUST close all idle sockets in its connection pool for the server:
if one socket is bad, it is likely that all are.

Clients MUST NOT request an immediate check of the server;
Expand Down