Skip to content

Small fixes for multi-user auth logic #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 15, 2019
Merged

Small fixes for multi-user auth logic #100

merged 1 commit into from
Feb 15, 2019

Conversation

adamchel
Copy link
Contributor

No description provided.

@adamchel adamchel requested a review from tkaye407 February 15, 2019 18:22
dkaminsky
dkaminsky approved these changes Feb 15, 2019
View reviewed changes
Copy link
Contributor

@dkaminsky dkaminsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

tkaye407
tkaye407 approved these changes Feb 15, 2019
View reviewed changes
Copy link
Contributor

@tkaye407 tkaye407 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

core/sdk/src/main/java/com/mongodb/stitch/core/auth/internal/CoreStitchAuth.java

protected StitchUserT loginWithCredentialInternal(final StitchCredential credential) {
authLock.writeLock().lock();
try {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol, good catch

@adamchel adamchel merged commit 65326d0 into mongodb:master Feb 15, 2019
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 65.959% when pulling bc4bfa2 on adamchel:small-auth-fix into ddd55d7 on mongodb:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkaye407 tkaye407 tkaye407 approved these changes

+1 more reviewer

@dkaminsky dkaminsky dkaminsky approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adamchel @coveralls @tkaye407 @dkaminsky