Skip to content

Conversation

adamchel
Copy link
Contributor

@adamchel adamchel commented Mar 1, 2019

This PR fixes a deadlock that was caused by the DataSynchronizer waiting for a stream to finish opening while the stream was waiting for the DataSynchronizer to release a lock. These changes are quite small, and mostly in the core remote mongo service.

This PR also adds an example app that can serve as a tool for us to do manual stress testing.

@adamchel adamchel requested a review from dkaminsky March 1, 2019 16:18
Copy link
Contributor

@dkaminsky dkaminsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, though wondering if those non-concurrent HashMaps in the instance listener impl are going to be problematic at some point

@coveralls
Copy link

coveralls commented Mar 2, 2019

Coverage Status

Coverage increased (+0.03%) to 66.86% when pulling 7ef6244 on adamchel:stress-testing into 5f88d96 on mongodb:master.

@adamchel adamchel merged commit f4c713c into mongodb:master Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants