STITCH-2263 - Android SDK: Always run R2L synchronization first #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkaminsky
changed the title
adamchel
approved these changes
Dec 18, 2018
README.md
Outdated
| 1. In Android Studio, go to Tools, Android, AVD manager. | ||
| 2. Click Create Virtual Device. | ||
| 3. Select a device that should run your app (the default is fine). | ||
| 3. Select a device that should run your app. |
There was a problem hiding this comment.
[nit] maybe add a note that the "default is not fine", since as of Android Studio 3.2 the default is x86, which does not work.
| 4. Select and download a recommended system image of your choice (the latest is fine). | ||
| * x86_64 images are available in the x86 tab. | ||
| * This device must a system image built on an architecture supported by the | ||
| ```libmongo``` library, e.g. x86_64 |
There was a problem hiding this comment.
[nit] maybe point to https://docs.mongodb.com/stitch/mongodb/mobile/getting-started/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per our decision, this commit removes the ability to (in code) swap from R2L first to L2R first behavior and eliminates the resulting duplicate test sequences. This change complies with our updated specification and ameliorates the need to make sure that all behaviors work across both directional preferences. Neither preference offered significant advantage to end users and complicated the logic when versions were missing during synchronization, as versions are not persisted locally.