SWIFT-1086 Ignore key order in array-nested documents in equalsIgnoreKeyOrder #56
Conversation
| continue | ||
| } | ||
| guard v == otherValue else { | ||
| guard let otherValue = other[k], v.equalsIgnoreKeyOrder(otherValue) else { |
There was a problem hiding this comment.
now that I think about it, shouldn't this method just not exist because a public BSONDocument.equalsIgnoreKeyOrder is already defined in the BSON library?
There was a problem hiding this comment.
Are you referring to BSON.equalsIgnoreKeyOrder? That's necessary (or rather helpful) to ease in recursion, since we have to go through BSON for both arrays and documents. If you mean BSONDocument.sortedEquals in the driver, then yeah that can be replaced with this. I originally tried doing that during the perf work but ran into this bug, so I had to implement it directly over there first. Once this is merged I'll open a follow-up PR updating the driver's implementation to just wrap this.
There was a problem hiding this comment.
lol whoops, I don't know why but I was thinking this was a PR against the driver itself 🤦♀️ nvm me
2 participants
Fix for SWIFT-1086