SWIFT-1088 ByteBuffer extJSON interoperability #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickfreed
changed the title
patrickfreed
commented
Feb 4, 2021
| // readBytes never returns nil here because we checked that the buffer wasn't empty and only read | ||
| // readable bytes out from it. | ||
| // swiftlint:disable:next force_unwrapping | ||
| return try self.decodeBytes(T.self, from: buffer.readBytes(length: buffer.readableBytes)!) |
There was a problem hiding this comment.
according to the swift-extras-json readme, it's more performant to read the bytes out of the buffer than it is to use ByteBufferView via readableBytesView. I think this is because the view relies on readInteger for each byte, which can be expensive to call repeatedly.
kmahar
approved these changes
Feb 4, 2021
There was a problem hiding this comment.
LGTM! did get me thinking about whether we should be showing example usage of our encoders and decoders in READMEs either here or on the driver itself which I opened SWIFT-1111 about (fun ticket number)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SWIFT-1088
This PR adds APIs to
ExtendedJSONEncoderandExtendedJSONDecoderwhich utilize NIO'sByteBufferinstead of Foundation'sData. This can help reduce needless copies when usingByteBufferthat would otherwise be required when routing throughData.