Skip to content

chore: Run Go tests using specific packages #2014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 13, 2024
Merged

chore: Run Go tests using specific packages #2014

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0c8f16d
generic
lantoli Mar 12, 2024
e7acbae
TEMPORARY: run always generic
lantoli Mar 12, 2024
986ebad
multi-line
lantoli Mar 12, 2024
d015c9c
fix yml
lantoli Mar 12, 2024
2822396
fix ACCTEST_PACKAGES
lantoli Mar 12, 2024
6073707
acc tests
lantoli Mar 13, 2024
97c0cf5
mig tests
lantoli Mar 13, 2024
66c96f6
Revert "TEMPORARY: run always generic"
lantoli Mar 13, 2024
50a1fc3
Merge branch 'master' into CLOUDP-237342_go_test_packages
lantoli Mar 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
88 changes: 68 additions & 20 deletions .github/workflows/acceptance-tests-runner.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,8 @@ env:
TF_ACC: 1
TF_LOG: ${{ vars.LOG_LEVEL }}
ACCTEST_TIMEOUT: ${{ vars.ACCTEST_TIMEOUT }}
ACCTEST_REGEX_RUN: "^TestAcc"
ACCTEST_REGEX_SKIP: "^TestAccMigration"
MONGODB_ATLAS_BASE_URL: ${{ inputs.mongodb_atlas_base_url }}
MONGODB_ATLAS_ORG_ID: ${{ inputs.mongodb_atlas_org_id }}
MONGODB_ATLAS_PUBLIC_KEY: ${{ secrets.mongodb_atlas_public_key }}
Expand Down Expand Up @@ -230,7 +232,7 @@ jobs:
terraform_wrapper: false
- name: Acceptance Tests
env:
TEST_REGEX: "^TestAccOutageSimulationCluster"
ACCTEST_PACKAGES: ./internal/service/clusteroutagesimulation
run: make testacc

advanced_cluster:
Expand All @@ -250,7 +252,7 @@ jobs:
terraform_wrapper: false
- name: Acceptance Tests
env:
TEST_REGEX: "^TestAccClusterAdvancedCluster"
ACCTEST_PACKAGES: ./internal/service/advancedcluster
run: make testacc

cluster:
Expand All @@ -270,7 +272,9 @@ jobs:
terraform_wrapper: false
- name: Acceptance Tests
env:
TEST_REGEX: "^TestAccClusterRS"
ACCTEST_PACKAGES: |
./internal/service/cluster
./internal/service/globalclusterconfig
run: make testacc

search_deployment:
Expand All @@ -290,7 +294,7 @@ jobs:
terraform_wrapper: false
- name: Acceptance Tests
env:
TEST_REGEX: "^TestAccSearchDeployment"
ACCTEST_PACKAGES: ./internal/service/searchdeployment
run: make testacc

stream:
Expand All @@ -311,7 +315,9 @@ jobs:
- name: Acceptance Tests
env:
MONGODB_ATLAS_ENABLE_PREVIEW: "true"
TEST_REGEX: "^TestAccStream"
ACCTEST_PACKAGES: |
./internal/service/streaminstance
./internal/service/streamconnection
run: make testacc

generic: # Acceptance tests that do not use any time-consuming resource (example: cluster)
Expand All @@ -333,9 +339,11 @@ jobs:
env:
MONGODB_ATLAS_PROJECT_OWNER_ID: ${{ inputs.mongodb_atlas_project_owner_id }}
CA_CERT: ${{ secrets.ca_cert }}
TEST_REGEX: "^TestAccGeneric"
run: |
make testacc
ACCTEST_PACKAGES: |
./internal/service/backupcompliancepolicy
./internal/service/auditing
./internal/service/x509authenticationdatabaseuser
run: make testacc
backup:
needs: [ change-detection ]
if: ${{ needs.change-detection.outputs.backup == 'true' || inputs.test_group == 'backup' }}
Expand All @@ -354,7 +362,13 @@ jobs:
- name: Acceptance Tests
env:
MONGODB_ATLAS_PROJECT_OWNER_ID: ${{ inputs.mongodb_atlas_project_owner_id }}
TEST_REGEX: "^TestAccBackup"
ACCTEST_PACKAGES: |
./internal/service/onlinearchive
./internal/service/cloudbackupschedule
./internal/service/cloudbackupsnapshot
./internal/service/cloudbackupsnapshotexportbucket
./internal/service/cloudbackupsnapshotexportjob
./internal/service/cloudbackupsnapshotrestorejob
run: make testacc
project:
needs: [ change-detection ]
Expand Down Expand Up @@ -383,7 +397,11 @@ jobs:
AWS_SECURITY_GROUP_2: ${{ vars.AWS_SECURITY_GROUP_2 }}
AWS_VPC_CIDR_BLOCK: ${{ vars.AWS_VPC_CIDR_BLOCK }}
AWS_VPC_ID: ${{ vars.AWS_VPC_ID }}
TEST_REGEX: "^TestAccProject"
ACCTEST_PACKAGES: |
./internal/service/project
./internal/service/projectipaccesslist
./internal/service/accesslistapikey
./internal/service/projectinvitation
run: make testacc
serverless:
needs: [ change-detection ]
Expand All @@ -402,7 +420,10 @@ jobs:
terraform_wrapper: false
- name: Acceptance Tests
env:
TEST_REGEX: "^TestAccServerless"
ACCTEST_PACKAGES: |
./internal/service/serverlessinstance
./internal/service/privatelinkendpointserverless
./internal/service/privatelinkendpointserviceserverless
run: make testacc
network:
needs: [ change-detection ]
Expand Down Expand Up @@ -431,7 +452,13 @@ jobs:
AWS_SECURITY_GROUP_2: ${{ vars.AWS_SECURITY_GROUP_2 }}
AWS_VPC_CIDR_BLOCK: ${{ vars.AWS_VPC_CIDR_BLOCK }}
AWS_VPC_ID: ${{ vars.AWS_VPC_ID }}
TEST_REGEX: "^TestAccNetwork"
ACCTEST_PACKAGES: |
./internal/service/networkcontainer
./internal/service/networkpeering
./internal/service/privateendpointregionalmode
./internal/service/privatelinkendpoint
./internal/service/privatelinkendpointservice
./internal/service/privatelinkendpointservicedatafederationonlinearchive
run: make testacc
config:
needs: [ change-detection ]
Expand All @@ -455,7 +482,21 @@ jobs:
AZURE_ATLAS_APP_ID: ${{ inputs.azure_atlas_app_id }}
AZURE_SERVICE_PRINCIPAL_ID: ${{ inputs.azure_service_principal_id }}
AZURE_TENANT_ID: ${{ inputs.azure_tenant_id }}
TEST_REGEX: "^TestAccConfig"
ACCTEST_PACKAGES: |
./internal/service/alertconfiguration
./internal/service/atlasuser
./internal/service/databaseuser
./internal/service/projectapikey
Comment on lines -458 to +489
Copy link
Member

@AgustinBettati AgustinBettati Mar 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like how each test group now defines explicitly which resources are included without relying on the naming indirection. Nice side benefit from the package restructure some months back.

./internal/service/apikey
./internal/service/teams
./internal/service/cloudprovideraccess
./internal/service/customdbrole
./internal/service/maintenancewindow
./internal/service/customdnsconfigurationclusteraws
./internal/service/rolesorgid
./internal/service/orginvitation
./internal/service/organization
./internal/service/thirdpartyintegration
run: make testacc

assume_role:
Expand Down Expand Up @@ -493,7 +534,7 @@ jobs:
AWS_ACCESS_KEY_ID: ${{ steps.sts-assume-role.outputs.aws_access_key_id }}
AWS_SECRET_ACCESS_KEY: ${{ steps.sts-assume-role.outputs.aws_secret_access_key }}
AWS_SESSION_TOKEN: ${{ steps.sts-assume-role.outputs.AWS_SESSION_TOKEN }}
TEST_REGEX: "^TestAccSTSAssumeRole"
ACCTEST_PACKAGES: ./internal/provider
run: make testacc

search_index:
Expand All @@ -513,7 +554,7 @@ jobs:
terraform_wrapper: false
- name: Acceptance Tests
env:
TEST_REGEX: "^TestAccSearchIndex"
ACCTEST_PACKAGES: ./internal/service/searchindex
run: make testacc

federated:
Expand Down Expand Up @@ -544,7 +585,12 @@ jobs:
AWS_REGION: ${{ vars.aws_region_federation }}
AWS_ACCESS_KEY_ID: ${{ secrets.aws_access_key_id }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.aws_secret_access_key }}
TEST_REGEX: "^TestAccFederated"
ACCTEST_PACKAGES: |
./internal/service/federatedsettingsidentityprovider
./internal/service/federateddatabaseinstance
./internal/service/federatedsettingsorgconfig
./internal/service/federatedsettingsorgrolemapping
./internal/service/federatedquerylimit
run: make testacc
data_lake:
needs: [ change-detection ]
Expand All @@ -563,7 +609,7 @@ jobs:
terraform_wrapper: false
- name: Acceptance Tests
env:
TEST_REGEX: "^TestAccDataLake"
ACCTEST_PACKAGES: ./internal/service/datalakepipeline
run: make testacc
ldap:
needs: [ change-detection ]
Expand All @@ -587,7 +633,9 @@ jobs:
MONGODB_ATLAS_LDAP_PASSWORD: ${{ secrets.mongodb_atlas_ldap_password }}
MONGODB_ATLAS_LDAP_PORT: ${{ secrets.mongodb_atlas_ldap_port }}
MONGODB_ATLAS_LDAP_CA_CERTIFICATE: ${{ secrets.mongodb_atlas_ldap_ca_certificate }}
TEST_REGEX: "^TestAccLDAP"
ACCTEST_PACKAGES: |
./internal/service/ldapconfiguration
./internal/service/ldapverify
run: make testacc
encryption:
needs: [ change-detection ]
Expand All @@ -606,7 +654,7 @@ jobs:
terraform_wrapper: false
- name: Acceptance Tests
env:
TEST_REGEX: "^TestAccEncryption"
ACCTEST_PACKAGES: ./internal/service/encryptionatrest
run: make testacc
event_trigger:
needs: [ change-detection ]
Expand All @@ -625,5 +673,5 @@ jobs:
terraform_wrapper: false
- name: Acceptance Tests
env:
TEST_REGEX: "^TestAccEventTrigger"
ACCTEST_PACKAGES: ./internal/service/eventtrigger
run: make testacc
Loading