This repository has been archived by the owner on Jan 15, 2024. It is now read-only.
[BUG FIX] Moped reconnects gracefully after a replica set reconfiguration #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion Default settings: * number of retries: 30 * sleep duration between retries: 1sec TODO: rspec tests
|
+1 |
|
Thanks... I'm looking at putting tests around this and pulling in. |
ghost
assigned
durran
added a commit
that referenced
this pull request
Oct 6, 2012
Moped::Session now can take 2 additional options, :retry_interval which is the time to wait before attempting an operation on a primary again, and :max_retries which is the maximum number of times to attempt the operation before raising an error. :retry_interval defaults to 1 (second). :max_retries defaults to 30. Instead of Moped attempting to perform an operation on the primary twice before raising an error, it now refreshes the node list and retries again up to the max number at retry intervals. Related to: #80, #60 Thanks to Nicolas Viennot for the initial pull request to set the base for the changes.
|
Okay I've pulled in and made some changes, most notably to be able to configure the time between retries and the max number. Thanks for the pull! |
durran
added a commit
that referenced
this pull request
Oct 6, 2012
Moped::Session now can take 2 additional options, :retry_interval which is the time to wait before attempting an operation on a primary again, and :max_retries which is the maximum number of times to attempt the operation before raising an error. :retry_interval defaults to 1 (second). :max_retries defaults to 30. Instead of Moped attempting to perform an operation on the primary twice before raising an error, it now refreshes the node list and retries again up to the max number at retry intervals. Related to: #80, #60 Thanks to Nicolas Viennot for the initial pull request to set the base for the changes.
|
Changes Unknown when pulling 0d8aa28 on nviennot:master into * on mongoid:master*. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default settings:
TODO: rspec tests
TODO: mongoid.yml