Feat: Add guidelines for alert/alert group name & array size #233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tests for `alert-name-length`
Tests the following: - Alert group name does not exceed 40 characters - Alert group array of alerts does not exceed 20 alerts
Dasomeone
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR and why is it needed?
This PR introduces guidelines for alerts & alert groups, in order for mixins to be compatible with Grafana Cloud out of the box, based on official rules limits.
Specifically the following limits have been introduced:
Appropriate tests have been added to check for these cases.
Additionally, as a drive-by, the
.gitignorehas been updated with exclusions for JetBrains IDEA temp files.