feat: support Emacs/Vim navigation in command line #4019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for both emacs and vim style navigation, which is muscle memory for a lot of people but currently unsupported in the main list view people use. Supporting both feels a lot more natural, and makes navigation easier for people that either don't have arrow keys at all or on their main layer
This is more likely to short circuit faster because ctrl isn't the common case
8 tasks
Miodec
pushed a commit
that referenced
this pull request
Oct 7, 2024
…xaskii) (#5949) ### Description Adds `<Ctrl-p>` and `<Ctrl-n>` binds to the command-line. These are from Emacs, but you can navigate up and down menus all over macOS and its apps with these keybinds. #### Relevant PRs Refactor that removed the binds: #5180 adding "vim keybinds": #4019 Confirmed working on macOS (safari, firefox, and chrome). On windows, `<Ctrl-n>`: opening a new window takes priority, but that's expected behaviour. ### Checks - [ ] Adding quotes? - [ ] Make sure to include translations for the quotes in the description (or another comment) so we can verify their content. - [ ] Adding a language or a theme? - [ ] If is a language, did you edit `_list.json`, `_groups.json` and add `languages.json`? - [ ] If is a theme, did you add the theme.css? - Also please add a screenshot of the theme, it would be extra awesome if you do so! - [x] Check if any open issues are related to this PR; if so, be sure to tag them below. - [x] Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info) - [x] Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title. <!-- label(optional scope): pull request title (@your_github_username) --> <!-- I know I know they seem boring but please do them, they help us and you will find out it also helps you.--> Closes issue discussed in discord. <!-- the issue(s) your PR resolves if any (delete if that is not the case) --> <!-- please also reference any issues and or PRs related to your pull request --> <!-- Also remove it if you are not following any issues. --> <!-- pro tip: you can mention an issue, PR, or discussion on GitHub by referencing its hash number e.g: [#1234](#1234) --> <!-- pro tip: you can press . (dot or period) in the code tab of any GitHub repo to get access to GitHub's VS Code web editor Enjoy! :) -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for moving the selection up and down in the command line with ctrl-n/p (emacs) and ctrl-j/k (vim), which is muscle memory for a lot of people but currently unsupported in the main list view people use.
Supporting both feels a lot more natural, and makes navigation easier for people that either don't have arrow keys at all or on their main layer (like myself!)