Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: enable no-unsafe-member-access (@miodec) #5887

Merged
merged 8 commits into from
Sep 18, 2024
Merged

refactor: enable no-unsafe-member-access (@miodec) #5887

merged 8 commits into from
Sep 18, 2024

Conversation

Miodec
Copy link
Member

@Miodec Miodec commented Sep 13, 2024

Description

Checks

  • Adding quotes?
    • Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • Adding a language or a theme?
    • If is a language, did you edit _list.json, _groups.json and add languages.json?
    • If is a theme, did you add the theme.css?
      • Also please add a screenshot of the theme, it would be extra awesome if you do so!
  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.

Closes #

@monkeytypegeorge monkeytypegeorge added backend Server stuff frontend User interface or web stuff packages Changes in local packages labels Sep 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@github-actions GitHub Actions
Copy link
Contributor

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@github-actions GitHub Actions
Copy link
Contributor

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

fehmer
fehmer reviewed Sep 14, 2024
View reviewed changes
backend/src/utils/auth.ts Outdated
const uid = (
await FirebaseAdmin()
.auth()
.getUserByEmail(email + 1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

email + 1?!

@Miodec Miodec merged commit 7e70302 into master Sep 18, 2024
11 checks passed
@Miodec Miodec deleted the no-unsafe-member-access branch September 18, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fehmer fehmer fehmer left review comments

Assignees
No one assigned
Labels
backend Server stuff frontend User interface or web stuff packages Changes in local packages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Miodec @fehmer @monkeytypegeorge