Skip to content

Modify SDK with Sentry code to make Sentry config easy and minimal in client app #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2023
Merged

Modify SDK with Sentry code to make Sentry config easy and minimal in client app #450

merged 1 commit into from
Mar 13, 2023

Conversation

rohitsharma120582
Copy link
Contributor

@rohitsharma120582 rohitsharma120582 commented Mar 13, 2023 •
edited
Loading

Technical description

  1. Modify SDK for Sentry code to make sentry configuration & setup easy and minimal in client apps
  2. Move sentry transaction code from InspectionCapture component (in client app) to Capture component (in SDK) to track whole capture tour
  3. Change the quit button with Controls.CloseEarlyButtonProps in place of Controls. GoBackButtonProps to handle the tour cancel and sentry transaction call respectively in Capture component

@rohitsharma120582
move maximum sentry code to SDK from the client app to make sentry co…
badabb8 
…nfiuration & setup minimal and easy in client apps
@rohitsharma120582 rohitsharma120582 temporarily deployed to development March 13, 2023 13:28 — with GitHub Actions Inactive
@rohitsharma120582 rohitsharma120582 temporarily deployed to development March 13, 2023 13:28 — with GitHub Actions Inactive
@rohitsharma120582 rohitsharma120582 merged commit bb3e1ba into main Mar 13, 2023
@rohitsharma120582 rohitsharma120582 deleted the fix/sentry-sdk-for-client branch March 13, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@souyahia-monk souyahia-monk souyahia-monk approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rohitsharma120582 @souyahia-monk