Skip to content

Restore successful github action build and nuget package generation #1946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Restore successful github action build and nuget package generation #1946

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a0d81e
Fix compat with newer MSVC headers
mitchcapper Sep 30, 2025
1aec6b9
Fix bitrot on github action so main workflow works again
mitchcapper Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
- uses: actions/checkout@v4

- name: Setup emsdk
uses: mymindstorm/setup-emsdk@v14
uses: pyodide/setup-emsdk@v15
with:
version: ${{ env.EMSCRIPTEN_VERSION }}
actions-cache-folder: emsdk-cache-${{ runner.os }}
Expand Down Expand Up @@ -113,7 +113,7 @@ jobs:
include/**/*.h

create_package:
runs-on: windows-2019
runs-on: windows-2022
needs: build
if: |
(github.event_name == 'push' && (github.ref == 'refs/heads/main' || contains(github.ref, 'nuget') || startsWith(github.ref, 'refs/tags/v'))) ||
Expand Down
1 change: 1 addition & 0 deletions src/Parser/ParserOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,7 @@ public void SetupMSVC(VisualStudioVersion vsVersion)
AddArguments("-fms-extensions");
AddArguments("-fms-compatibility");
AddArguments("-fdelayed-template-parsing");
AddArguments("-D_ALLOW_COMPILER_AND_STL_VERSION_MISMATCH");
}

/// <summary>
Expand Down