Skip to content

[docs] Migrate Custom Fields API page #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 15, 2023
Merged

[docs] Migrate Custom Fields API page #637

merged 1 commit into from
Sep 15, 2023

Conversation

roland04
Copy link
Collaborator

No description provided.

@netlify
Copy link

netlify bot commented May 23, 2023 •
edited
Loading

✅ Deploy Preview for moodledevdocs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 8384515
🔍 Latest deploy log https://app.netlify.com/sites/moodledevdocs/deploys/650455783df4520008c479f4
😎 Deploy Preview https://deploy-preview-637--moodledevdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@roland04 roland04 force-pushed the devdocs-customfields branch from 1fa4c8a to 6c9c705 Compare May 23, 2023 12:54
@roland04 roland04 changed the title Add Custom Fields API page [docs] Migrate Custom Fields API page May 23, 2023
@roland04 roland04 force-pushed the devdocs-customfields branch from 6c9c705 to c080be0 Compare May 23, 2023 13:03
@github-actions
Copy link
Contributor

github-actions bot commented May 23, 2023 •
edited
Loading

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 72 🟠 87 🟢 92 🟢 90 🟢 100 Report
/docs/apis/commonfiles 🔴 41 🟠 85 🟢 92 🟢 100 🟢 100 Report
/general/development/gettingstarted 🟠 51 🟠 87 🟢 92 🟢 90 🟢 100 Report
/general/releases 🟠 50 🟠 87 🟢 92 🟢 100 🟢 100 Report

@roland04 roland04 force-pushed the devdocs-customfields branch 2 times, most recently from aad720e to 46ccc51 Compare August 25, 2023 12:56
@roland04 roland04 marked this pull request as ready for review August 25, 2023 13:20
sarjona
sarjona requested changes Sep 13, 2023
View reviewed changes
Copy link
Member

@sarjona sarjona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @roland04!
Thanks for migrating this page. The content looks good and, as you'll see, most of the suggestions are related to improve style and readability ;-)
Let me know once you finish to review it again :-)

@roland04 roland04 force-pushed the devdocs-customfields branch 2 times, most recently from 92bda95 to 0e3dbd7 Compare September 13, 2023 14:49
@roland04 roland04 requested a review from sarjona September 13, 2023 14:50
@roland04
Copy link
Collaborator Author

Thanks a lot @sarjona for the detailed review. I learned a lot about how to migrate future doc pages 😃

sarjona
sarjona requested changes Sep 15, 2023
View reviewed changes
Copy link
Member

@sarjona sarjona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @roland04!
Thanks for reviewing the patch. As you'll see, we're almost there (there are only a couple of minor things that it would be better to change) :-)

@roland04 roland04 force-pushed the devdocs-customfields branch from 0e3dbd7 to 8384515 Compare September 15, 2023 13:00
@roland04
Copy link
Collaborator Author

Thanks a lot for your patience @sarjona. Changes done!

sarjona
sarjona approved these changes Sep 15, 2023
View reviewed changes
Copy link
Member

@sarjona sarjona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mikel! Good work!! <3

@sarjona sarjona added this pull request to the merge queue Sep 15, 2023
Merged via the queue into moodle:main with commit 6163b92 Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarjona sarjona sarjona approved these changes

Assignees
No one assigned
Labels
waiting-for-feedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roland04 @sarjona