Skip to content

MOBILE-4891 bootstrap: Fix crossfading transition #4569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2025
Merged

MOBILE-4891 bootstrap: Fix crossfading transition #4569

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/core/singletons/bootstrap.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import { CorePopovers } from '@services/overlays/popovers';
import { CoreFormatTextOptions } from '@components/bs-tooltip/bs-tooltip';
import { CoreModals } from '@services/overlays/modals';
import { CoreDom } from './dom';
import { CoreWait } from './wait';

/**
* Singleton with helper functions for Bootstrap.
Expand Down Expand Up @@ -459,7 +460,7 @@ export class CoreBootstrap {
};

// Helper to perform slide/crossfade transition.
const goToSlide = (newIndex: number, direction: 'next' | 'prev') => {
const goToSlide = async (newIndex: number, direction: 'next' | 'prev') => {
const items = Array.from(element.querySelectorAll<HTMLElement>('.carousel-item'));
const activeIndex = items.findIndex(item => item.classList.contains('active'));
if (newIndex === activeIndex || newIndex < 0 || newIndex >= items.length) {
Expand All @@ -475,8 +476,8 @@ export class CoreBootstrap {

// Animation.
nextItem.classList.add(direction === 'next' ? 'carousel-item-next' : 'carousel-item-prev');
// Force reflow for transition.
void nextItem.offsetWidth;
// Wait the render to finish to start the transition.
await CoreWait.nextTick();

activeItem.classList.add(direction === 'next' ? 'carousel-item-start' : 'carousel-item-end');
nextItem.classList.add(direction === 'next' ? 'carousel-item-start' : 'carousel-item-end');
Expand Down