-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to polkadot v1.1.0 #2499
Conversation
Looks good so far (I know it's not done yet :) ) |
92c8b6d
to
88722b0
Compare
Coverage generated "Tue Oct 10 10:10:49 UTC 2023": Master coverage: 87.39% |
02da56b
to
a403c2d
Compare
6e5f333
to
e819d76
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far, haven't made it through everything yet but wanted to push my comments so far.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I left some comments that are worth reviewing though :)
- `check --release` is done. - `check --tests` is in progress
- `check --tests` is in progress
- `check --tests` is done
This reverts commit 8fb8e24.
6547e2f
to
7ee2ad9
Compare
What does it do?
Upgrades the dependencies
polkadot-sdk
frontier
moonkit
orml
pallet-crowdloans
to the version
moonbeam-polkadot-v1.1.0
.What important points reviewers should know?
Breaking Changes
Eth::new
accepts two additional parameters:pending_create_inherent_data_providers
: which requires time inherent and ,in our case,ParachainInherentData
provider. Since these are needed in a pending context, providing dummy values is enough.pending_consensus_data_provider
: Through which we providednimbus author id
(by getting it from the last best block) andvrf
digests.test/suites/dev/test-xcm-v3/test-mock-dmp-queue.ts
.try-runtime
subcommand has been removed and migrated to the standalone-cli.AllowPaidExecutionFrom
barrier now prevents multiple currency transfers.polkadot-sdk
has new names:xcm
->staging-xcm
xcm-executor
->staging-xcm-executor
xcm-builder
->staging-xcm-builder
kusama-runtime
->staging-kusama-runtime
XcmVersionedXcm
message in the ts tests has been renamed toStagingXcmVersionedXcm
frame_system::Config
,Index
was renamed toNonce
BlockNumber
,Header
andHoldIdentifier
were removedBlock
,Aliasers
andRuntimeHoldReason
were addedparas::Config
has a new associated typeOnNewHead
hrmp::Config
has a new associated typeChannelManager
pallet_message_queue::Config
has a new associated typeQueuePausedQuery
build_storage
andassimilate_storage
is now provided viasp_runtime::BuildStorage
instead offrame_support::traits::GenesisBuild
xcm_executor::traits::Convert
was replaced withxcm_executor::traits::ConvertLocation
whose APIs differ.improved_panic_error_reporting
feature insp_io
andchain-error
inparity-scale-codec
to pass certain test cases.hrmp::WeightInfo::force_open_hrmp_channel
accepts a newu32
argumentWeightTrader::buy_weight
method takes an additionalXcmContext
parameter.pallet_xcm_benchmarks::generic::Config
requires a new methodalias_origin
Is there something left for follow-up PRs?
start_full_node
andstart_collator
APIsmoonriver-native
should be renamed.What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?