Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to polkadot v1.1.0 #2499

Merged
merged 62 commits into from
Oct 10, 2023
Merged

Upgrade to polkadot v1.1.0 #2499

merged 62 commits into from
Oct 10, 2023

Conversation

rimbi
Copy link
Contributor

@rimbi rimbi commented Sep 22, 2023

What does it do?

Upgrades the dependencies

  • polkadot-sdk
  • frontier
  • moonkit
  • orml
  • pallet-crowdloans

to the version moonbeam-polkadot-v1.1.0.

What important points reviewers should know?

Breaking Changes

  • Eth::new accepts two additional parameters:
    • pending_create_inherent_data_providers: which requires time inherent and ,in our case, ParachainInherentData provider. Since these are needed in a pending context, providing dummy values is enough.
    • pending_consensus_data_provider: Through which we provided nimbus author id (by getting it from the last best block) and vrf digests.
  • The number of instructions in an XCM message is limited to 100. This effects the test in test/suites/dev/test-xcm-v3/test-mock-dmp-queue.ts.
  • try-runtime subcommand has been removed and migrated to the standalone-cli.
  • AllowPaidExecutionFrom barrier now prevents multiple currency transfers.
  • The following crates in the polkadot-sdk has new names:
    • xcm -> staging-xcm
    • xcm-executor -> staging-xcm-executor
    • xcm-builder -> staging-xcm-builder
    • kusama-runtime -> staging-kusama-runtime
  • In accordance with the above changes the XcmVersionedXcm message in the ts tests has been renamed to StagingXcmVersionedXcm
  • In frame_system::Config,
    • the Index was renamed to Nonce
    • BlockNumber, Header and HoldIdentifier were removed
    • Block, Aliasers and RuntimeHoldReason were added
  • paras::Config has a new associated type OnNewHead
  • hrmp::Config has a new associated type ChannelManager
  • pallet_message_queue::Config has a new associated type QueuePausedQuery
  • build_storage and assimilate_storage is now provided via sp_runtime::BuildStorage instead of frame_support::traits::GenesisBuild
  • The use of xcm_executor::traits::Convert was replaced with xcm_executor::traits::ConvertLocation whose APIs differ.
  • Removal of native runtime execution required to enable improved_panic_error_reporting feature in sp_io and chain-error in parity-scale-codec to pass certain test cases.
  • hrmp::WeightInfo::force_open_hrmp_channel accepts a new u32 argument
  • WeightTrader::buy_weight method takes an additional XcmContext parameter.
  • pallet_xcm_benchmarks::generic::Config requires a new method alias_origin

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

@rimbi rimbi self-assigned this Sep 22, 2023
@notlesh
Copy link
Contributor

notlesh commented Sep 22, 2023

Looks good so far (I know it's not done yet :) )

@rimbi rimbi changed the title [WIP] Upgrade to polkadot v1.1.0 Upgrade to polkadot v1.1.0 Sep 25, 2023
@rimbi rimbi marked this pull request as ready for review September 25, 2023 09:00
@rimbi rimbi force-pushed the cem-upgrade-to-polkadot-v1.1.0 branch from 92c8b6d to 88722b0 Compare September 25, 2023 09:52
@rimbi rimbi added B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. breaking Needs to be mentioned in breaking changes labels Sep 25, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2023

Coverage generated "Tue Oct 10 10:10:49 UTC 2023":
https://d3ifz9vhxc2wtb.cloudfront.net/pulls/2499/html/index.html

Master coverage: 87.39%
Pull coverage:

@rimbi rimbi force-pushed the cem-upgrade-to-polkadot-v1.1.0 branch from 02da56b to a403c2d Compare September 26, 2023 13:56
@notlesh notlesh added D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited and removed D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Sep 27, 2023
runtime/common/src/lib.rs Outdated Show resolved Hide resolved
runtime/common/src/apis.rs Outdated Show resolved Hide resolved
runtime/common/src/lib.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@notlesh notlesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, haven't made it through everything yet but wanted to push my comments so far.

node/service/src/lib.rs Show resolved Hide resolved
node/service/src/lib.rs Outdated Show resolved Hide resolved
pallets/parachain-staking/src/inflation.rs Show resolved Hide resolved
precompiles/utils/macro/src/precompile/expand.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@notlesh notlesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I left some comments that are worth reviewing though :)

Cem Eliguzel added 4 commits October 10, 2023 08:54
- `check --release` is done.
- `check --tests` is in progress
- `check --tests` is in progress
- `check --tests` is done
@rimbi rimbi force-pushed the cem-upgrade-to-polkadot-v1.1.0 branch from 6547e2f to 7ee2ad9 Compare October 10, 2023 09:27
@rimbi rimbi merged commit 7fee3fd into master Oct 10, 2023
26 checks passed
@rimbi rimbi deleted the cem-upgrade-to-polkadot-v1.1.0 branch October 10, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants