Skip to content

improve @fs API #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 22, 2025
Merged

improve @fs API #10

merged 5 commits into from
Jul 22, 2025

Conversation

Guest0x0
Copy link
Collaborator

improve API of @fs:

  • fix read: make it return the number of bytes actually read for proper EOF handling
  • fix write: ensure all data successfully written
  • read and write: make len an optional argument & add offset argument
  • add API for file seeking and getting file size
  • add document to all @fs API

@Guest0x0 Guest0x0 merged commit 3a917c5 into main Jul 22, 2025
9 checks passed
@Guest0x0 Guest0x0 deleted the more-file-op branch July 22, 2025 07:26
@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 50

Details

  • 12 of 13 (92.31%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 81.749%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/fs/fs.mbt 12 13 92.31%
Totals Coverage Status
Change from base Build 49: 0.1%
Covered Lines: 430
Relevant Lines: 526
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Guest0x0