refactor process API, integrate with native task system & cancellation #22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the API of
@process
. Previously, the API is non-structural. The spawned process is orphan, and may leak if not properly waited. The previous API cannot integrate with structured concurrency as well.This PR replaces
@process.spawn
with@process.run
, Compared to@process.spawn
,@process.run
will wait until the spawned process completes. And if current task is cancelled, the spawned process will be terminated viaSIGTERM
, making process spawning structural.Previous behavior can still be recovered partially:
spawn
orspawn_bg
orphan=true
to@process.run