remove some unnecessary/wrong [to_string] methods #1490
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since MoonBit allows calling
impl
with dot syntax now, it is no longer necessary to defineto_string
method wrappers to support.to_string()
usage. This PR remove such unnecessaryto_string
wrapper methods.One of the removed methods,
Result::to_string
in@result
, actually has wrong behavior, forgetting to escape its arguments when necessary. This PR fixes the issue.I also added tests for the
Show
impls.