test: improve coverage for quickcheck/splitmix/random.mbt

[rami3l]

Disclaimer: This PR was generated by an LLM agent as part of an experiment.

Summary

coverage of `quickcheck/splitmix/random.mbt`: 76.2% -> 95.2%

[peter-jerry-ye-code-review]

‼️ This code review is generated by a bot. Please verify the content before trusting it.

⚠️ [Incorrect assertion in next_float test]

• Category: Correctness
• Code Snippet:

  inspect!(result <= 1.0, content="false")

• Recommendation: Change to content="true"
• Reasoning: The test claims to verify random floats fall within [0, 1], but currently asserts the float is greater than 1.0 due to inverted boolean check. This would cause false test failures and mask actual implementation errors.

💡 [Insufficient clone validation]

• Category: Correctness
• Code Snippet:

  let orig_int = state.next_int()
  let clone_int = cloned.next_int()
  inspect!(orig_int == clone_int, ...)

• Recommendation: Add multiple consecutive value comparisons
• Reasoning: Only testing one generated value leaves room for undetected divergence in state progression. A robust clone should produce identical sequences across multiple calls.

⚠️ [Non-deterministic test pattern]

• Category: Maintainability
• Code Snippet:

  let state = @splitmix.new()  // in next_two_uint test

• Recommendation: Explicit seed like @splitmix.new(seed=42UL)
• Reasoning: Tests relying on default RNG initialization are fragile. Explicit seeds make tests reproducible and resistant to upstream initialization changes.

[coveralls]

Pull Request Test Coverage Report for Build 5079

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.07%) to 85.568%

---

Totals
Change from base Build 5075:	0.07%
Covered Lines:	5259
Relevant Lines:	6146

---

💛 - Coveralls