Skip to content

Conversation

bobzhang
Copy link
Contributor

@bobzhang bobzhang commented Feb 8, 2025

cc @Young-Flash any idea why this was not caught by the CI?

@bobzhang bobzhang requested a review from Young-Flash February 8, 2025 10:26
@coveralls
Copy link
Collaborator

coveralls commented Feb 8, 2025

Pull Request Test Coverage Report for Build 5306

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.902%

Totals Coverage Status
Change from base Build 5300: 0.0%
Covered Lines: 5580
Relevant Lines: 6348

💛 - Coveralls

@Yu-zh
Copy link
Collaborator

Yu-zh commented Feb 8, 2025

The package is used by the native backend but not other backends. moon should collect the warnings from moonc and when the unused package warning applies to all the backends, the warning should be reported to the user.

@Young-Flash Young-Flash force-pushed the hongbo/remove_unused_package branch from 1e47351 to 6cc0d06 Compare February 11, 2025 10:02
@Young-Flash Young-Flash enabled auto-merge (squash) February 11, 2025 10:03
@Young-Flash Young-Flash merged commit 88ee03a into main Feb 11, 2025
16 checks passed
@Young-Flash Young-Flash deleted the hongbo/remove_unused_package branch February 11, 2025 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants