refactor(strconv): accept string view for pub api #2474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peter-jerry-ye
force-pushed
the
zihang/update-strconv
branch
from
b26b52d to
8313e2c
Compare
Pull Request Test Coverage Report for Build 498Details
💛 - Coveralls |
peter-jerry-ye
commented
Jul 22, 2025
Comment on lines
+40
to
+48
| loop s { | ||
| ['0'..='9' as ch, .. rest] if x < min_19digit_int => { | ||
| len += 1 | ||
| x = x * 10UL + | ||
| UInt64::extend_uint((ch.to_int() - '0').reinterpret_as_uint()) // no overflows here | ||
| continue rest | ||
| } | ||
| len += 1 | ||
| x = x * 10UL + UInt64::extend_uint(to_digit(s[0]).reinterpret_as_uint()) // no overflows here | ||
| s = s.step_1_unchecked() | ||
| ['_', .. rest] => continue rest | ||
| s => return (s, x, len) |
There was a problem hiding this comment.
This is the only place where the new implementation differs from the original, as the original one looks like a bug to me where it didn't check again whether the first char is still a digit after having consumed a -. The test coverage suggests that such behavior was never tested.
bobzhang
force-pushed
the
zihang/update-strconv
branch
from
245f622 to
37d5f45
Compare
bobzhang
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and replace the string slice by string view.
TODO : Update the
FromStrtrait to accept the@string.Viewas well.