refactor: migrate is_leading_surrogate/is_trailing_surrogate to Int methods #2502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ethods - Add Int::is_leading_surrogate() and Int::is_trailing_surrogate() methods - Replace all function calls with method calls throughout the codebase - Remove duplicate function definitions from builtin/string.mbt and string/utils.mbt - Clean up unused surrogate range constants This provides a more consistent API by making these UTF-16 surrogate checks available as methods on the Int type itself.
Pull Request Test Coverage Report for Build 549Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a more consistent API by making these UTF-16 surrogate checks
available as methods on the Int type itself.