Skip to content

use built in get_code_info rather than depending on Sub::Identify #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 18, 2020
Merged

use built in get_code_info rather than depending on Sub::Identify #178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions TODO
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,12 +81,6 @@ method by that name, so it'll depend on the previous fix going in (so "has foo
There's no actual reason for this not to work, and it gets asked often enough
that we really should just do it at some point.

### use Sub::Identify instead of doing our own thing with `get_code_info`

No idea why we stopped using Sub::Identify in the past, but there's no reason
not to do this. We have a bug fix in our version (the `isGV_with_GP` thing), so
this should be submitted to Sub::Identify first.

## Needs Thought

These are things we think are good ideas, but they need more fleshing out.
Expand Down
2 changes: 0 additions & 2 deletions dist.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,8 +301,6 @@ code = s{^(note 'Checking Changes')}{if \(\(\$ENV\{TRAVIS_PULL_REQUEST\} \|\| ''
;authordep Scalar::Util = 1.19
Sub::Exporter = 0.980
;authordep Sub::Exporter = 0.980
Sub::Identify = 0
;authordep Sub::Identify = 0
Sub::Name = 0.20
;authordep Sub::Name = 0.20
Try::Tiny = 0.17
Expand Down
6 changes: 3 additions & 3 deletions lib/Class/MOP/Mixin/HasOverloads.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ use Class::MOP::Overload;

use Devel::OverloadInfo 0.005 'overload_info', 'overload_op_info';
use Scalar::Util 'blessed';
use Sub::Identify 'sub_name', 'stash_name';

use overload ();

Expand Down Expand Up @@ -66,11 +65,12 @@ sub add_overloaded_operator {
$overload = Class::MOP::Overload->new(%p);
}
elsif ( !blessed $overload) {
my ($coderef_package, $coderef_name) = Class::MOP::get_code_info($overload);
$overload = Class::MOP::Overload->new(
operator => $op,
coderef => $overload,
coderef_name => sub_name($overload),
coderef_package => stash_name($overload),
coderef_name => $coderef_name,
coderef_package => $coderef_package,
%p,
);
}
Expand Down