Cache number parser to not create too many instances #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to parse and save some memory. On the Lucene model we allocate more than 2.000.000 number parsers.
|
Did you see some performance improvement? |
|
With Seba's profiler I see that we reduce by almost 10% the allocated size in memory during an import of a medium size model. There is a little gain of speed but it's not huge because this represent just a small part of the import but also because we tweak the GC parameters to have a big young space (64MB instead of 2.8MB). I guess that without this change of parameter we would have a bigger difference. I was thinking to propose to reuse the same Parser in Number/Integer>>#readFrom:* methods but that would cause problems in case of concurrency since the class NumberParser has states. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change caches the number parser. During the import of a model the number parser represented 5% en the objects created. With this change we only create 1.