Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Juneteenth holiday to Time calendar #234

Merged
merged 2 commits into from
Jun 14, 2022

Conversation

mhargrove
Copy link
Contributor

Add Juneteenth to the list of standard national holidays as per https://www.federalreserve.gov/aboutthefed/k8.htm

(this can be reverted if rickar/cal#93 is merged & released)

time.go Outdated Show resolved Hide resolved
@adamdecaf
Copy link
Member

adamdecaf commented Jun 14, 2022

I thought this was already handled by the library. I added it to the cal library before.

This was partially added, but fixed in https://github.com/rickar/cal/releases/tag/v2.1.5

@adamdecaf
Copy link
Member

You can merge this and rebase #235 so we can merge that as well.

Releases are a git tag on the commit that updates the changelog. We copy that into the Github release

@mhargrove mhargrove merged commit 52562ea into moov-io:master Jun 14, 2022
@mhargrove mhargrove deleted the add-juneteenth branch June 14, 2022 17:48
@mhargrove mhargrove mentioned this pull request Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants