feat: Add AddBusinessDay to Time #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darwinz
reviewed
Jun 14, 2022
darwinz
previously approved these changes
Jun 14, 2022
adamdecaf
reviewed
Jun 14, 2022
Codecov Report
@@ Coverage Diff @@
## master #235 +/- ##
==========================================
+ Coverage 77.42% 77.58% +0.16%
==========================================
Files 29 29
Lines 939 946 +7
==========================================
+ Hits 727 734 +7
Misses 166 166
Partials 46 46
Continue to review full report at Codecov.
|
adamdecaf
approved these changes
Jun 15, 2022
|
Thank you! Since this adds to the public API let's release v0.31.0 with the changelog updated. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
AddBusinessDayto TimeNote: this is built on top of #234 & assumes those changes are complete for the sake of accurate test data, compare mhargrove/base@add-juneteenth...mhargrove:add-business-day for unique changes