Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EBCDIC 1047 encoder & prefixer #190

Merged
merged 2 commits into from
Aug 1, 2022

Conversation

Dakinola892
Copy link
Contributor

EBCDIC has many code pages with slightly different encodings for characters.

Code Page 1047 is a commonly used EBCDIC spec with encodings that differ from the EBCDIC encoder already provided, so an additional encoder to handle encoding to this spec might be useful addition

@Dakinola892 Dakinola892 requested a review from alovak as a code owner July 29, 2022 13:23
@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2022

Codecov Report

Merging #190 (9280f19) into master (151e28e) will increase coverage by 0.30%.
The diff coverage is 82.97%.

@@            Coverage Diff             @@
##           master     #190      +/-   ##
==========================================
+ Coverage   70.91%   71.21%   +0.30%     
==========================================
  Files          38       40       +2     
  Lines        1798     1845      +47     
==========================================
+ Hits         1275     1314      +39     
- Misses        336      340       +4     
- Partials      187      191       +4     
Impacted Files Coverage Δ
encoding/ebcdic1047.go 73.33% <73.33%> (ø)
prefix/ebcdic1047.go 87.50% <87.50%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 151e28e...9280f19. Read the comment docs.

@Dakinola892 Dakinola892 requested a review from alovak August 1, 2022 12:07
Copy link
Contributor

@alovak alovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!!

@alovak alovak merged commit 11ed597 into moov-io:master Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants