field: nil check Numeric, String, Composite, etc accessors

[adamdecaf]

Issue: #195

[codecov-commenter]

Codecov Report

Base: 71.21% // Head: 71.30% // Increases project coverage by +0.08% 🎉

Coverage data is based on head (3940453) compared to base (68aee25).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #196      +/-   ##
==========================================
+ Coverage   71.21%   71.30%   +0.08%     
==========================================
  Files          40       40              
  Lines        1845     1847       +2     
==========================================
+ Hits         1314     1317       +3     
+ Misses        340      339       -1     
  Partials      191      191              

Impacted Files	Coverage Δ
field/string.go	77.33% <100.00%> (+1.99%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[alovak]

This is a really good change to make code simpler for the callers

[adamdecaf]

@alovak Cool. I can add this to every field type.

[alovak]

thanks @adamdecaf! this PR looks 💪

the only thing that (kind of) worries me is that GetValue. On message we have GetString(), GetBytes(). But on field we have String() and Bytes() and now we add GetValue().

We can introduce a breaking change by adding Value() and SetValue() and renaming Value into value. It will make code more consistent and safe. In my personal opinion, such change is just find/replace so it should not be a PITA.

thoughts?

[adamdecaf]

Yea I agree that GetValue() isn't idea and I'm okay with that breaking change. It's minor enough and increases runtime safety.

[adamdecaf]

@alovak feel free to merge this whenever you want. I know there are other 8583 changes in flight.