Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing int64 support for String field Unmarshal #303

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

alovak
Copy link
Contributor

@alovak alovak commented Jan 12, 2024

We forgot to handle the int64 type when we Unmarshal field. The following code returned the error unsupported reflect.Value type: int64:

	data := struct {
		MTI               string `index:"0"`
		TransactionAmount int64  `index:"4"`
	}
	err := msg.Unrashal(&data)
	// handle error

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6ecba23) 74.86% compared to head (6fe69f3) 74.98%.

❗ Current head 6fe69f3 differs from pull request most recent head 54b929f. Consider uploading reports for the commit 54b929f to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #303      +/-   ##
==========================================
+ Coverage   74.86%   74.98%   +0.12%     
==========================================
  Files          44       44              
  Lines        2495     2495              
==========================================
+ Hits         1868     1871       +3     
+ Misses        411      407       -4     
- Partials      216      217       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alovak alovak merged commit 27feb74 into master Jan 12, 2024
9 checks passed
@alovak alovak deleted the fix-string-unmarshal branch January 12, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants