Persistent modifiers on partial release of modifier combo. Fixes #74 #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 1, 2020
rbreaves
changed the title
…in some circumstances
This was referenced May 7, 2020
|
Withdrawing these fixes as it appears to also break the modifier persistence. I may just work on creating a separate HK function and then resubmit a fix. This way the functionality of keeping a held modifiers in sync with the original modifier will not interfere with some users desires to emit shortcut keys instead of keeping them fully in sync with the original key press. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently this issue has existed going back to even May 2019, and my changes to the on release behavior of modifier keys had kept that original behavior. It has been resolved now by checking the actual key released against the possible modifiers to be released. Newly mapped modifiers are released separately (also known as missing modifiers in output.py).
Original commit 8c4fadb introduced the bug, while fixing similar modifier key behaviors.
More info in the thread. #74