Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate persistent_store setting #706

Merged

Conversation

andsel
Copy link
Collaborator

@andsel andsel commented Jan 21, 2023

Release notes

Deprecate persistent_store to separate the enablement of persistence with persistence_enabled and the path data_path.

What does this PR do?

Introduce data_path setting to refer the location where to save data files for subscription and queues stores; by default data folder under $MOQUETTE_HOME.
Introduces also, persistence_enabled boolean setting to explicitly enable persistent or in memory storage.

Why is it important/What is the impact to the user?

The existing persistent_store setting pointed to a single H2 file. If the setting is not valued, implicitly mean to store in-memory.
With the introduction of segmented queues storage type, there is the need to define a directory where to store segmented pages, so a folder. Its default value is data folder under Moquette installation folder.
Given that the data_path has always a value there is the requirement for a flag to explicitly enable/disable the persistence.

@andsel andsel self-assigned this Jan 21, 2023
@andsel andsel marked this pull request as ready for review January 21, 2023 14:54
@andsel andsel merged commit 3f4200b into moquette-io:main Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant