Deprecate persistent_store setting #706
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
Deprecate
persistent_store
to separate the enablement of persistence withpersistence_enabled
and the pathdata_path
.What does this PR do?
Introduce
data_path
setting to refer the location where to save data files for subscription and queues stores; by defaultdata
folder under$MOQUETTE_HOME
.Introduces also,
persistence_enabled
boolean setting to explicitly enable persistent or in memory storage.Why is it important/What is the impact to the user?
The existing
persistent_store
setting pointed to a single H2 file. If the setting is not valued, implicitly mean to store in-memory.With the introduction of
segmented
queues storage type, there is the need to define a directory where to store segmented pages, so a folder. Its default value isdata
folder under Moquette installation folder.Given that the
data_path
has always a value there is the requirement for a flag to explicitly enable/disable the persistence.