Sets clientId into Channel's attribute immediately after processing he CONNECT message #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he connect MQTT 3.1.1 specification, MQTT-3.1.4-5 says that Clients are allowed to send further Control Packets immediately after sending a CONNECT Packet. In this case a PUBLISH is could be sent immediately after the CONNECT, so it's processed serially by the same IO thread. The PUBLISH needs to accees the clientID attribute of the Channel, so it needs be set before the CONNACK in write&flush.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MQTT 3.1.1 specification, MQTT-3.1.4-5 says that Clients are allowed to send further Control Packets immediately after sending a CONNECT Packet. In this case a PUBLISH is could be sent immediately after the CONNECT, so it's processed serially by the same IO thread. The PUBLISH needs to accees the clientID attribute of the Channel, so it needs be set before the CONNACK in write&flush.
Fixes #705