Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid decomposition of Publish fields into method params #827

Merged
merged 6 commits into from
Apr 20, 2024

Conversation

andsel
Copy link
Collaborator

@andsel andsel commented Apr 19, 2024

Release notes

Refactory of PostOffice to pass publish message in hits entirety avoiding decomposition into single parameters.

What does this PR do?

Updated all PostOffice methods that accepted QoS, topic, retained flag and payload, components of a publish message to move around just the publish message without decomposing it.

Why is it important/What is the impact to the user?

As developer I want to have the smallest and cohesive parameters list passed around method calls.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files (and/or docker env variables)
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • I have updated the Changelog if it's a feature or a fix that has to be reported

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

@andsel andsel added the mqtt5 label Apr 19, 2024
@andsel andsel self-assigned this Apr 19, 2024
@andsel andsel changed the title Fix/use mqtt message in param list Avoid decomposition of Publish fields into method params Apr 20, 2024
@andsel andsel marked this pull request as ready for review April 20, 2024 09:48
@andsel andsel merged commit ac2a9be into moquette-io:main Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant