Switch from raw Net::HTTP to Faraday #2
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've modified the gem to use Faraday, as opposed to raw Net::HTTP. I know this adds a potentially unwanted dependency, but Faraday is very common these days. By default, it uses Net::HTTP so the performance should be identical.
The reason for this is because now if someone wanted to increase the performance of the gem, they could swap out the HTTP backend to be Typhoeus or similar, using something like this:
All tests are passing for me but I welcome any comments